mirror of
https://github.com/webstudio-is/webstudio.git
synced 2026-11-09 14:03:33 +09:00
faeef3bd4fdac48a650a29c7028d15bad8accd35
Closes https://github.com/webstudio-is/webstudio/issues/3025 ## Description Allow having the same page path if the full path is different through folder slug ## Steps for reproduction Case 1 1. create a folder with slug /1 and another with slug /2 2. create page with path /p in folder 1 3. create page with path /p in folder 2 4. see that this is allowed Case 2 1. create a foder 1 with empty slug and folder 2 with empty slug 2. create page with path /p in folder 1 3. create page with path /p in folder 2 4. see that this is not allowed ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 5de6) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env.example` and the `builder/env-check.js` if mandatory
Learning Resources
- Blog
- Documentation
- Brand and Product Design
- Contributing Guide for Devs
- Github Discussions
- Wishlist
- Builder Issues Tracker
- Roadmap
Social Media
Thanks
Thanks to Lost Pixel for providing the visual testing platform that helps us review UI changes and catch visual regressions.
Languages
TypeScript
98.9%
PLpgSQL
0.5%
CSS
0.3%
Shell
0.2%
JavaScript
0.1%
