mirror of
https://github.com/webstudio-is/webstudio.git
synced 2026-11-07 12:33:36 +09:00
Oleg Isonen
77b8dab455
## Description There are multiple problems with clipping to text: 1. it is only supported with vendor prefixed -webkit-background-clip 2. it doesn't work with CSS vars (not using them on canvas for this) ## Steps for reproduction 1. add heading 4. set background image src to some image 5. set color to transparent 6. set background-clip to text 7. Background image should be clipped to text <img width="294" alt="Screenshot 2023-02-24 at 13 49 22" src="https://user-images.githubusercontent.com/52824/221194656-9e4591ed-5727-45f0-8560-eba35e278819.png"> ## Code Review - [ ] hi @TrySound , I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 5de6) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio-builder/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env.example` and the `builder/env-check.js` if mandatory
Webstudio Builder
Webstudio Builder is a NoCode Visual Tool inspired by Webflow. It is the place where you can build your site or app visually.
Contributing
Don't hesitate to reach out of you have questions around contributing to the project.