mirror of
https://github.com/cozystack/cozystack.git
synced 2026-11-09 14:02:56 +09:00
test(monitoring): pin the oidc values passthrough to the inner chart
The wrapper hands the whole of .Values to the inner chart verbatim, so that one line is the only path by which a tenant-set spec.oidc reaches the chart which renders it. Nothing pinned that hop: the inner chart's own suite sets its values directly, so a wrapper that dropped or renamed a key would still render a correct inner chart -- from values no tenant can actually set. Verified by mutation: replacing the passthrough with `omit .Values "oidc"` fails exactly this case's three assertions and leaves the other three cases in the file green. This is the one item from the deleted monitoring OIDC bats that live coverage was genuinely carrying and unit coverage was not, and it costs no cluster. Signed-off-by: Myasnikov Daniil <myasnikovdaniil2001@gmail.com>
This commit is contained in:
1 file changed
+22
@@ -25,6 +25,28 @@ tests:
|
||||
path: spec.waitStrategy.name
|
||||
value: poller
|
||||
|
||||
# The wrapper hands the whole of .Values to the inner chart verbatim, so this is
|
||||
# the only path by which a tenant-set field such as spec.oidc reaches the chart
|
||||
# that renders it. Nothing else pinned that hop: packages/system/monitoring's own
|
||||
# suite sets its values directly, so a wrapper that dropped or renamed a key
|
||||
# would still render a correct inner chart — from values no tenant can set.
|
||||
- it: passes tenant-set oidc values through to the inner chart
|
||||
set:
|
||||
oidc.mode: System
|
||||
oidc.users:
|
||||
- email: alice@example.com
|
||||
role: Admin
|
||||
asserts:
|
||||
- equal:
|
||||
path: spec.values.oidc.mode
|
||||
value: System
|
||||
- equal:
|
||||
path: spec.values.oidc.users[0].email
|
||||
value: alice@example.com
|
||||
- equal:
|
||||
path: spec.values.oidc.users[0].role
|
||||
value: Admin
|
||||
|
||||
- it: gates readiness on the VLCluster status.updateStatus
|
||||
asserts:
|
||||
- equal:
|
||||
|
||||
Reference in new issue
Block a user