Aleksei Sviridkin
13a2a0fd2e
## What this PR does Preserves Kubernetes write options when the application, tenant-secret, and security-group APIs delegate create, update, and delete operations to controller-runtime. Passing an API options object only through `client.*Options.Raw` is insufficient because controller-runtime's `As*Options()` methods rebuild `Raw` from the typed fields; dry-run, field manager, field validation, delete propagation, grace periods, and preconditions were silently lost. The new converters populate the typed client options, and all affected application, tenant-secret, and security-group paths use them. The force-create PUT path preserves the caller's options as well. TenantSecret PATCH is served through Get and Update. Backend rejections surfaced by these writes now keep their machine-readable status on the wire: the application storage rebuilds the `StatusError` with context instead of flattening it through `fmt.Errorf`, so a quota or admission rejection answers 403/409 with its reason instead of a generic 500 with none. Tap storage uses a different client and is outside this change. This was reproduced on Cozystack 1.6.1: `kubectl apply --dry-run=server` against an `apps.cozystack.io` resource performed a real write and created the release. Validation: - `go test ./pkg/registry/...`: passed. - `go test -race ./pkg/registry/...`: passed. - `make generate`: no diff. - `make manifests`: no diff. ### Screenshots Not a UI change. ### Downstream repositories Walked the trigger map against the registry implementation and tests. No external schema, CRD, package layout, tooling anchor, or downstream hardcoded contract changes. - [x] No downstream repository is affected by this change - [ ] [cozystack/website](https://github.com/cozystack/website) - follow-up: - [ ] [cozystack/terraform-provider-cozystack](https://github.com/cozystack/terraform-provider-cozystack) - follow-up: - [ ] [cozystack/ansible-cozystack](https://github.com/cozystack/ansible-cozystack) - follow-up: - [ ] [cozystack/ccp](https://github.com/cozystack/ccp) - follow-up: - [ ] [cozystack/talm](https://github.com/cozystack/talm) - follow-up: - [ ] [cozystack/cozyhr](https://github.com/cozystack/cozyhr) - follow-up: - [ ] [cozystack/cozy-proxy](https://github.com/cozystack/cozy-proxy) - follow-up: - [ ] [cozystack/cozystack-telemetry-server](https://github.com/cozystack/cozystack-telemetry-server) - follow-up: - [ ] [cozystack/external-apps-example](https://github.com/cozystack/external-apps-example) - follow-up: - [ ] [cozystack/examples](https://github.com/cozystack/examples) - follow-up: ### Release note ```release-note fix(registry): preserve dry-run and other Kubernetes write options in application, tenant-secret, and security-group storage operations, and keep backend error statuses on the wire ``` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - REST create, update, and delete operations now preserve request options such as dry-run, field management, validation, deletion propagation, and preconditions. - Force-create and HelmRelease update requests now retain their supplied options. - Dry-run security group deletions now accurately report their prospective completion state without modifying stored data. - Delete and other REST errors now preserve their original status, reason, and HTTP code while adding context. - **Tests** - Added coverage for write-option handling across applications, tenant secrets, security groups, and shared option conversions. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Cozystack
Cozystack is a free and open-source platform and framework for building clouds.
Cozystack is a CNCF Sandbox project that was originally built and sponsored by Ænix.
With Cozystack, you can transform a bunch of servers into an intelligent system with a simple REST API for spawning Kubernetes clusters, Database-as-a-Service, virtual machines, load balancers, HTTP caching services, and other services with ease.
Use Cozystack to build your own cloud or provide a cost-effective development environment.
Use-Cases
-
Using Cozystack to build a public cloud
You can use Cozystack as a backend for a public cloud -
Using Cozystack to build a private cloud
You can use Cozystack as a platform to build a private cloud powered by Infrastructure-as-Code approach -
Using Cozystack as a Kubernetes distribution
You can use Cozystack as a Kubernetes distribution for Bare Metal
Documentation
The documentation is located on the cozystack.io website.
Read the Getting Started section for a quick start.
If you encounter any difficulties, start with the troubleshooting guide and work your way through the process that we've outlined.
Versioning
Versioning adheres to the Semantic Versioning principles.
A full list of the available releases is available in the GitHub repository's Release section.
Contributions
Contributions are highly appreciated and very welcomed!
In case of bugs, please check if the issue has already been opened by checking the GitHub Issues section. If it isn't, you can open a new one. A detailed report will help us replicate it, assess it, and work on a fix.
You are welcome to take on the fix yourself. Commits are used to generate the changelog, and their author will be referenced in it.
If you have a concrete feature request, open an issue. For a cross-cutting or architectural change, open a design proposal in the community repo. For questions or early ideas, use GitHub Discussions. See CONTRIBUTING.md for the full routing.
Community
You are welcome to join us in #cozystack, on either CNCF Slack (get an invite) or Kubernetes Slack (get an invite), in our Telegram group, and at our community meetings. Add them to your Google Calendar or iCal for convenience.
Project documents
| Document | What it covers |
|---|---|
| Governance | How decisions are made and who makes them |
| Contributor Ladder | How to grow from contributor to maintainer |
| Maintainers | Who maintains the project |
| Code of Conduct | What we expect of each other |
| Security Policy | Reporting a vulnerability, and which releases get fixes |
| Adopters | Who runs Cozystack in production |
| Roadmap | Where the project is going |
License
Cozystack is licensed under Apache 2.0.
The code is provided as-is with no warranties.
Commercial Support
A list of companies providing commercial support for this project can be found on official site.