Aleksei Sviridkin 15e87fdbea fix(seaweedfs): remove identities left behind by deleted BucketAccesses (#4915)
## What this PR does

Removes SeaweedFS identities left behind by deleted BucketAccesses. The
COSI driver up to v0.3.1 revokes only from the legacy `identity.json`,
while SeaweedFS since 4.08 keeps each identity in its own file, so those
files stayed (seaweedfs/seaweedfs-cosi-driver#11). The upstream driver
v0.4.0 from #5284 deletes the file on revoke, so no new files are left.
Files that v0.3.1 already left behind still hold working keys and stay
until something removes them.

A post-install/post-upgrade hook in `seaweedfs-system` removes them. It
lists the identity files before the BucketAccesses, so a file whose
BucketAccess still exists is never taken for a left-over one. The rest
of the rules are in the commit message and at the top of the script.
When it is unsure, it removes nothing, and the errors it handles do not
fail the release.

A filer that other clusters use through Client topology holds identities
whose BucketAccesses this cluster cannot see. The new
`cosi.orphanIdentities` value of the SeaweedFS application decides what
happens there. The default `auto` only reports when `filer.grpcHost` is
set and removes otherwise, and an operator can force `report` or
`delete`.

This builds on #4893, which is now merged.

Tested with bats against a fake `weed shell` and with helm-unittest. A
mutation that swaps the two listings back makes the ordering test fail.
An earlier revision of the script, which also skipped recently changed
files, was tried on a live cluster with SeaweedFS 4.45 and driver
v0.3.1. It only reported in report mode and removed left-over files in
delete mode while live identities kept working. With BucketAccess
listing forbidden, it removed nothing. The current revision has not been
run on a live cluster. No run has checked that the keys of a removed
identity are then rejected.

On 045f1a9bbc the bats, chart tests, Helm lint of the system chart and
shellcheck pass offline. The Linux unit lane and E2E are pending.

### Screenshots

Not a UI change.

### Downstream repositories

The new value belongs to the SeaweedFS application, which the Terraform
provider does not model (it only sets `seaweedfs` on a Tenant). The
website reference page is regenerated from the README on release.

- [x] No downstream repository is affected by this change
- [ ] [cozystack/website](https://github.com/cozystack/website) -
follow-up:
- [ ]
[cozystack/terraform-provider-cozystack](https://github.com/cozystack/terraform-provider-cozystack)
- follow-up:
- [ ]
[cozystack/ansible-cozystack](https://github.com/cozystack/ansible-cozystack)
- follow-up:
- [ ] [cozystack/ccp](https://github.com/cozystack/ccp) - follow-up:
- [ ] [cozystack/talm](https://github.com/cozystack/talm) - follow-up:
- [ ] [cozystack/cozyhr](https://github.com/cozystack/cozyhr) -
follow-up:
- [ ] [cozystack/cozy-proxy](https://github.com/cozystack/cozy-proxy) -
follow-up:
- [ ]
[cozystack/cozystack-telemetry-server](https://github.com/cozystack/cozystack-telemetry-server)
- follow-up:
- [ ]
[cozystack/external-apps-example](https://github.com/cozystack/external-apps-example)
- follow-up:
- [ ] [cozystack/examples](https://github.com/cozystack/examples) -
follow-up:
- [ ] [cozystack/community](https://github.com/cozystack/community) -
follow-up:

### Release note

```release-note
fix(seaweedfs): remove S3 identities left behind by deleted BucketAccesses on install and upgrade. The new cosi.orphanIdentities value (auto, report, delete) controls it; auto only reports on a filer published to Client-topology clusters.
```








<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

<!-- coderabbit-ai-generated:v1 -->

## Summary by CodeRabbit

* **New Features**
* SeaweedFS COSI installations can configure how identities left by
deleted BucketAccess resources are handled: report them, delete them, or
use automatic behavior. Automatic mode reports them when the filer is
published and deletes them otherwise; Client topology ignores this
setting.
* Post-install and post-upgrade checks can add missing Object Lock
actions to eligible identities and report unresolved changes through
Kubernetes Warning Events.
* Orphan identity handling reports findings and, in delete mode, removes
eligible identities. Checks avoid removal when listings fail or no live
BucketAccess resources are found.
* **Documentation**
* Added configuration guidance and clarified the SeaweedFS volume size
limit setting.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-11-18 01:41:23 +03:00
2026-11-04 00:56:56 +01:00
2025-10-08 09:43:34 +05:00
2024-02-08 12:04:32 +01:00

Cozystack Cozystack

GitHub Release Apache-2.0 License Commit activity OpenSSF Best Practices OpenSSF Scorecard CLOMonitor Support

Cozystack

Cozystack is a free and open-source platform and framework for building clouds.

Cozystack is a CNCF Sandbox project that was originally built and sponsored by Ænix.

With Cozystack, you can transform a bunch of servers into an intelligent system with a simple REST API for spawning Kubernetes clusters, Database-as-a-Service, virtual machines, load balancers, HTTP caching services, and other services with ease.

Use Cozystack to build your own cloud or provide a cost-effective development environment.

Cozystack user interface

Use-Cases

Documentation

The documentation is located on the cozystack.io website.

Read the Getting Started section for a quick start.

If you encounter any difficulties, start with the troubleshooting guide and work your way through the process that we've outlined.

Versioning

Versioning adheres to the Semantic Versioning principles.
A full list of the available releases is available in the GitHub repository's Release section.

Contributions

Contributions are highly appreciated and very welcomed!

In case of bugs, please check if the issue has already been opened by checking the GitHub Issues section. If it isn't, you can open a new one. A detailed report will help us replicate it, assess it, and work on a fix.

You are welcome to take on the fix yourself. Commits are used to generate the changelog, and their author will be referenced in it.

If you have a concrete feature request, open an issue. For a cross-cutting or architectural change, open a design proposal in the community repo. For questions or early ideas, use GitHub Discussions. See CONTRIBUTING.md for the full routing.

Community

You are welcome to join us in #cozystack, on either CNCF Slack (get an invite) or Kubernetes Slack (get an invite), in our Telegram group, and at our community meetings. Add them to your Google Calendar or iCal for convenience.

Project documents

Document What it covers
Governance How decisions are made and who makes them
Contributor Ladder How to grow from contributor to maintainer
Maintainers Who maintains the project
Code of Conduct What we expect of each other
Security Policy Reporting a vulnerability, and which releases get fixes
Adopters Who runs Cozystack in production
Roadmap Where the project is going

License

Cozystack is licensed under Apache 2.0.
The code is provided as-is with no warranties.

Commercial Support

A list of companies providing commercial support for this project can be found on official site.

Languages
Go 52%
Shell 34%
TypeScript 6.8%
Go Template 4.7%
Makefile 1.3%
Other 1.1%