Aleksei Sviridkin 31711685e0 fix(workloadmonitor): populate VM instance-profile label from the KubeVirt preference annotation (#4448)
## What this PR does

The WorkloadMonitor reconciler copies a VM's instance profile onto the
`workloads.cozystack.io/kubevirt-vmi-instance-profile` label of the
`Workload` object, which the billing metric pipeline consumes.
`getWorkloadMetadata` read the annotation
`kubevirt.io/cluster-instanceprofile-name`, but KubeVirt never stamps
that key: it records the cluster preference (which carries the guest OS
profile) under `kubevirt.io/cluster-preference-name`. So the profile
label was never populated, and a VM's instance profile — a Windows
guest, for example — never reached billing. The sibling instance-type
label worked only because its key,
`kubevirt.io/cluster-instancetype-name`, is the real one.

This reads the correct annotation. The emitted label name is unchanged,
so the rest of the pipeline is untouched. The wrong key appears exactly
once in the tree, at the read site, and nothing writes it;
`kubevirt.io/cluster-preference-name` is the constant
`ClusterPreferenceAnnotation` in `kubevirt.io/api` (`core/v1/types.go`),
while no `cluster-instanceprofile-name` constant exists there.

Verified on a dev cluster: with the fix, a Windows-profile VM's
virt-launcher pod (which carries `kubevirt.io/cluster-preference-name =
windows.2k22.virtio`) now yields the
`workloads.cozystack.io/kubevirt-vmi-instance-profile` label on its
`Workload`, and the profile propagates through the billing metric
pipeline into the usage report's lifetime record. A table test pins the
exact annotation key, keeps the instance-type case as a control, and
asserts the nonexistent old key yields no label.

### Downstream repositories

Walked the trigger map against the diff: this is an internal controller
label-key fix, with no change to any CRD, values.schema.json, chart
values, hack/*, namespace, variant, release asset, or telemetry metric.
No listed downstream repository is affected.

- [x] No downstream repository is affected by this change

### Release note

```release-note
fix(workloadmonitor): populate the VM instance-profile billing label from the KubeVirt cluster-preference annotation so VM instance profiles (for example Windows) reach billing
```


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Bug Fixes**
* Workload metadata now uses KubeVirt’s cluster preference annotation
for the instance-profile label. The unsupported cluster instance-profile
annotation is ignored.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-09-24 21:20:48 +04:00
2025-10-08 09:43:34 +05:00
2024-02-08 12:04:32 +01:00

Cozystack Cozystack

GitHub Release Apache-2.0 License Commit activity OpenSSF Best Practices OpenSSF Scorecard CLOMonitor Support

Cozystack

Cozystack is a free and open-source platform and framework for building clouds.

Cozystack is a CNCF Sandbox project that was originally built and sponsored by Ænix.

With Cozystack, you can transform a bunch of servers into an intelligent system with a simple REST API for spawning Kubernetes clusters, Database-as-a-Service, virtual machines, load balancers, HTTP caching services, and other services with ease.

Use Cozystack to build your own cloud or provide a cost-effective development environment.

Cozystack user interface

Use-Cases

Documentation

The documentation is located on the cozystack.io website.

Read the Getting Started section for a quick start.

If you encounter any difficulties, start with the troubleshooting guide and work your way through the process that we've outlined.

Versioning

Versioning adheres to the Semantic Versioning principles.
A full list of the available releases is available in the GitHub repository's Release section.

Contributions

Contributions are highly appreciated and very welcomed!

In case of bugs, please check if the issue has already been opened by checking the GitHub Issues section. If it isn't, you can open a new one. A detailed report will help us replicate it, assess it, and work on a fix.

You are welcome to take on the fix yourself. Commits are used to generate the changelog, and their author will be referenced in it.

If you have a concrete feature request, open an issue. For a cross-cutting or architectural change, open a design proposal in the community repo. For questions or early ideas, use GitHub Discussions. See CONTRIBUTING.md for the full routing.

Community

You are welcome to join us in #cozystack, on either CNCF Slack (get an invite) or Kubernetes Slack (get an invite), in our Telegram group, and at our community meetings. Add them to your Google Calendar or iCal for convenience.

Project documents

Document What it covers
Governance How decisions are made and who makes them
Contributor Ladder How to grow from contributor to maintainer
Maintainers Who maintains the project
Code of Conduct What we expect of each other
Security Policy Reporting a vulnerability, and which releases get fixes
Adopters Who runs Cozystack in production
Roadmap Where the project is going

License

Cozystack is licensed under Apache 2.0.
The code is provided as-is with no warranties.

Commercial Support

A list of companies providing commercial support for this project can be found on official site.

Languages
Go 52%
Shell 34%
TypeScript 6.8%
Go Template 4.7%
Makefile 1.3%
Other 1.1%