Aleksei Sviridkin 8741fb31f9 fix(vm-instance): keep an external PortList VM valid with no ports (#5270)
## What this PR does

A `vm-instance` with `external: true`, `externalMethod: PortList` and an
empty `externalPorts` list renders a `LoadBalancer` Service with no port
at all. The API server rejects it (`Service "vm-instance-<name>" is
invalid: spec.ports: Required value`), so the HelmRelease fails on every
retry. The previous Service stays in place meanwhile, which means the
ports the user believes they removed are still open.

Emptying the list is a legitimate request: keep the VM's external IP
(egress SNAT, ICMP) but expose no inbound port. This PR renders a single
placeholder port in that case, `65535/SCTP`, named `no-ports`. The
protocol is the point: cozy-proxy's `EnsurePortFilter` only admits TCP
and UDP ports into `allowed_ports` and skips anything else, while the
pod still enters `filtered_pods`, so every inbound TCP and UDP packet is
dropped. A TCP or UDP placeholder would open that port on the VM
instead.

The `WholeIP` branch and the non-external branch keep their existing
`65535` placeholder unchanged.

Tested on a lab cluster running cozy-proxy with node-local rules,
against a running PortList VM exposing 22 and 80: with the placeholder
Service, MetalLB kept the same IP, cozy-proxy logged `Skipping
unsupported protocol for port filter` and kept the egress SNAT and
ingress DNAT, TCP 22, 80 and 65535 timed out from outside, ICMP still
answered (`allowICMP: "true"`), and the Cilium agents logged nothing
about the Service. Restoring the port list reopened 22 and 80.

`tests/service_ports_test.yaml` covers the three external cases. Its
first case fails on `main` (`unknown path spec.ports[0]`) and passes
with the fix.

### Screenshots

Not a UI change.

### Downstream repositories

Walked the trigger map against the diff (`templates/service.yaml` and a
new unit test in `packages/apps/vm-instance`): no package is added or
renamed, no value, schema, default or annotation changes, and the
`service-proxy-name` label and the `wholeIP` / `allowICMP` annotations
cozy-proxy matches on are untouched. The fix does rely on cozy-proxy
ignoring non-TCP/UDP ports in its port filter, which holds on cozy-proxy
`main` today; if it ever learns SCTP, this placeholder would open
`65535/SCTP` and nothing else.

- [x] No downstream repository is affected by this change
- [ ] [cozystack/website](https://github.com/cozystack/website) -
follow-up:
- [ ]
[cozystack/terraform-provider-cozystack](https://github.com/cozystack/terraform-provider-cozystack)
- follow-up:
- [ ]
[cozystack/ansible-cozystack](https://github.com/cozystack/ansible-cozystack)
- follow-up:
- [ ] [cozystack/ccp](https://github.com/cozystack/ccp) - follow-up:
- [ ] [cozystack/talm](https://github.com/cozystack/talm) - follow-up:
- [ ] [cozystack/cozyhr](https://github.com/cozystack/cozyhr) -
follow-up:
- [ ] [cozystack/cozy-proxy](https://github.com/cozystack/cozy-proxy) -
follow-up:
- [ ]
[cozystack/cozystack-telemetry-server](https://github.com/cozystack/cozystack-telemetry-server)
- follow-up:
- [ ]
[cozystack/external-apps-example](https://github.com/cozystack/external-apps-example)
- follow-up:
- [ ] [cozystack/examples](https://github.com/cozystack/examples) -
follow-up:
- [ ] [cozystack/community](https://github.com/cozystack/community) -
follow-up:

### Release note

```release-note
fix(vm-instance): an external PortList VM with an empty port list no longer fails to deploy; it keeps its external IP and blocks all inbound TCP and UDP traffic.
```


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

<!-- coderabbit-ai-generated:v1 -->

## Summary by CodeRabbit

* **Bug Fixes**
* External services without configured ports now include an SCTP
placeholder on port 65535, except for `WholeIP` services, whose existing
behavior is unchanged.
* Services with configured ports continue to render those ports without
the placeholder. This keeps the rendered service configuration
consistent across these cases.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-11-13 12:20:42 +03:00
2025-10-08 09:43:34 +05:00
2024-02-08 12:04:32 +01:00

Cozystack Cozystack

GitHub Release Apache-2.0 License Commit activity OpenSSF Best Practices OpenSSF Scorecard CLOMonitor Support

Cozystack

Cozystack is a free and open-source platform and framework for building clouds.

Cozystack is a CNCF Sandbox project that was originally built and sponsored by Ænix.

With Cozystack, you can transform a bunch of servers into an intelligent system with a simple REST API for spawning Kubernetes clusters, Database-as-a-Service, virtual machines, load balancers, HTTP caching services, and other services with ease.

Use Cozystack to build your own cloud or provide a cost-effective development environment.

Cozystack user interface

Use-Cases

Documentation

The documentation is located on the cozystack.io website.

Read the Getting Started section for a quick start.

If you encounter any difficulties, start with the troubleshooting guide and work your way through the process that we've outlined.

Versioning

Versioning adheres to the Semantic Versioning principles.
A full list of the available releases is available in the GitHub repository's Release section.

Contributions

Contributions are highly appreciated and very welcomed!

In case of bugs, please check if the issue has already been opened by checking the GitHub Issues section. If it isn't, you can open a new one. A detailed report will help us replicate it, assess it, and work on a fix.

You are welcome to take on the fix yourself. Commits are used to generate the changelog, and their author will be referenced in it.

If you have a concrete feature request, open an issue. For a cross-cutting or architectural change, open a design proposal in the community repo. For questions or early ideas, use GitHub Discussions. See CONTRIBUTING.md for the full routing.

Community

You are welcome to join us in #cozystack, on either CNCF Slack (get an invite) or Kubernetes Slack (get an invite), in our Telegram group, and at our community meetings. Add them to your Google Calendar or iCal for convenience.

Project documents

Document What it covers
Governance How decisions are made and who makes them
Contributor Ladder How to grow from contributor to maintainer
Maintainers Who maintains the project
Code of Conduct What we expect of each other
Security Policy Reporting a vulnerability, and which releases get fixes
Adopters Who runs Cozystack in production
Roadmap Where the project is going

License

Cozystack is licensed under Apache 2.0.
The code is provided as-is with no warranties.

Commercial Support

A list of companies providing commercial support for this project can be found on official site.

Languages
Go 52%
Shell 34%
TypeScript 6.8%
Go Template 4.7%
Makefile 1.3%
Other 1.1%