Aleksei Sviridkin a4537127e7 fix(vertical-pod-autoscaler): run two admission controllers spread over nodes (#5098)
## What this PR does

The VPA admission controller runs as one replica, and its webhook is
registered with `failurePolicy: Ignore`. While that one pod is being
rescheduled, every pod created in the cluster is admitted without its
VPA recommendation, and with `updateMode: Initial` it keeps those
resources until it is recreated. On a v1.6.5 cluster
`vmstorage-shortterm-0` was created during a node drain while the
admission controller moved to another node. It has no `vpaUpdates`
annotation and runs with the vm-operator defaults, requests 250m/500Mi
and limits 1/1500Mi, while its VPA recommends 920m and 3.42Gi and the
other replica got 5.13Gi through VPA. It was OOMKilled 18 days later.

This PR sets `replicaCount: 2`, enables the chart's PodDisruptionBudget
with `minAvailable: 1` and spreads the two replicas over nodes with a
`ScheduleAnyway` topology spread, so single-node clusters still schedule
both. A drain then leaves one controller serving. The controller still
deletes and recreates its MutatingWebhookConfiguration on start
(`selfRegistration` in `pkg/admission-controller/config.go`, VPA 1.5.1),
so a restart leaves only that short gap instead of the whole reschedule.
`failurePolicy` stays `Ignore`, a VPA outage should not block pod
creation.

Two new cases in `tests/vpa_test.yaml` check the replica count, the
spread selector against the pod labels and the PDB. `helm unittest .` in
`packages/system/vertical-pod-autoscaler` passes 18 of 18 with
helm-unittest 1.1.2, and against the values on main the two new cases
fail and the other 16 pass. `helm template` renders the Deployment with
2 replicas and the PDB with the admission controller selector. I have
not run the change on a live cluster.

#4540 is the same trap from the other side, a component that keeps a bad
size because Initial never revisits it.

### Screenshots

Not a UI change.

### Downstream repositories

Values of `packages/system/vertical-pod-autoscaler` and its tests only.
No platform values, app schema, default exposed to tenants or package
change, so no trigger map entry applies.

- [x] No downstream repository is affected by this change
- [ ] [cozystack/website](https://github.com/cozystack/website) -
follow-up:
- [ ]
[cozystack/terraform-provider-cozystack](https://github.com/cozystack/terraform-provider-cozystack)
- follow-up:
- [ ]
[cozystack/ansible-cozystack](https://github.com/cozystack/ansible-cozystack)
- follow-up:
- [ ] [cozystack/ccp](https://github.com/cozystack/ccp) - follow-up:
- [ ] [cozystack/talm](https://github.com/cozystack/talm) - follow-up:
- [ ] [cozystack/cozyhr](https://github.com/cozystack/cozyhr) -
follow-up:
- [ ] [cozystack/cozy-proxy](https://github.com/cozystack/cozy-proxy) -
follow-up:
- [ ]
[cozystack/cozystack-telemetry-server](https://github.com/cozystack/cozystack-telemetry-server)
- follow-up:
- [ ]
[cozystack/external-apps-example](https://github.com/cozystack/external-apps-example)
- follow-up:
- [ ] [cozystack/examples](https://github.com/cozystack/examples) -
follow-up:
- [ ] [cozystack/community](https://github.com/cozystack/community) -
follow-up:

### Release note

```release-note
fix(vertical-pod-autoscaler): the admission controller runs two replicas spread over nodes with a PodDisruptionBudget, so pods created during a drain still get their VPA recommendation.
```


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
<!-- coderabbit-ai-generated:v1 -->

## Summary by CodeRabbit

* **Improvements**
* The VPA admission controller now runs with two replicas, increasing
availability.
* Its pods are spread across hostnames when scheduling permits, helping
reduce the impact of node-level disruptions.
* A disruption budget requires at least one admission-controller pod to
remain available during voluntary disruptions.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-11-13 16:32:43 +03:00
2026-11-13 12:57:32 +00:00
2025-10-08 09:43:34 +05:00
2024-02-08 12:04:32 +01:00

Cozystack Cozystack

GitHub Release Apache-2.0 License Commit activity OpenSSF Best Practices OpenSSF Scorecard CLOMonitor Support

Cozystack

Cozystack is a free and open-source platform and framework for building clouds.

Cozystack is a CNCF Sandbox project that was originally built and sponsored by Ænix.

With Cozystack, you can transform a bunch of servers into an intelligent system with a simple REST API for spawning Kubernetes clusters, Database-as-a-Service, virtual machines, load balancers, HTTP caching services, and other services with ease.

Use Cozystack to build your own cloud or provide a cost-effective development environment.

Cozystack user interface

Use-Cases

Documentation

The documentation is located on the cozystack.io website.

Read the Getting Started section for a quick start.

If you encounter any difficulties, start with the troubleshooting guide and work your way through the process that we've outlined.

Versioning

Versioning adheres to the Semantic Versioning principles.
A full list of the available releases is available in the GitHub repository's Release section.

Contributions

Contributions are highly appreciated and very welcomed!

In case of bugs, please check if the issue has already been opened by checking the GitHub Issues section. If it isn't, you can open a new one. A detailed report will help us replicate it, assess it, and work on a fix.

You are welcome to take on the fix yourself. Commits are used to generate the changelog, and their author will be referenced in it.

If you have a concrete feature request, open an issue. For a cross-cutting or architectural change, open a design proposal in the community repo. For questions or early ideas, use GitHub Discussions. See CONTRIBUTING.md for the full routing.

Community

You are welcome to join us in #cozystack, on either CNCF Slack (get an invite) or Kubernetes Slack (get an invite), in our Telegram group, and at our community meetings. Add them to your Google Calendar or iCal for convenience.

Project documents

Document What it covers
Governance How decisions are made and who makes them
Contributor Ladder How to grow from contributor to maintainer
Maintainers Who maintains the project
Code of Conduct What we expect of each other
Security Policy Reporting a vulnerability, and which releases get fixes
Adopters Who runs Cozystack in production
Roadmap Where the project is going

License

Cozystack is licensed under Apache 2.0.
The code is provided as-is with no warranties.

Commercial Support

A list of companies providing commercial support for this project can be found on official site.

Languages
Go 52%
Shell 34%
TypeScript 6.8%
Go Template 4.7%
Makefile 1.3%
Other 1.1%