Aleksei Sviridkin ecca3b2af5 feat(kubernetes): configure per-pool Talos sysctls (#5254)
<!-- Thank you for making a contribution! Here are some tips for you:
- Use Conventional Commits for the PR title: `type(scope): description`
- Types: feat, fix, security (a fix that comes through a security
advisory), docs, style, refactor, perf, test, build, ci, chore
- Scopes are not an exhaustive list — pick the most specific scope for
the change and extend the list when a genuinely new area appears.
Examples:
- System components: dashboard, platform, operator, cilium, kube-ovn,
linstor, fluxcd, cluster-api
- Managed apps: postgres, mariadb, redis, kafka, clickhouse,
virtual-machine, kubernetes
- Development and maintenance: api, hack, tests, ci, docs, maintenance
- Breaking changes: append `!` after type/scope (`feat(api)!: ...`) or
add a `BREAKING CHANGE:` footer
- If it's a work in progress, consider creating this PR as a draft.
- Don't hesistate to ask for opinion and review in the community chats,
even if it's still a draft.
- Fixes merged to `main` reach the release lines the backport batch runs
for automatically, so do not open backport PRs by hand:
https://github.com/cozystack/cozystack/blob/main/docs/release/backports.md
-->

## What this PR does

Adds an optional `KubernetesNodes.spec.talos.sysctls` string map,
rendered into `machine.sysctls` on that pool's guest workers. This lets
operators configure the user namespaces needed by the Talos gVisor
extension without adding a dedicated API field for each future sysctl.

Replaces the proposal in #4650, following [the suggestion to expose a
general sysctl
map](https://github.com/cozystack/cozystack/pull/4650#issuecomment-6743092045).
This is a new branch from `main`, not a stack on the original PR. The
suggestion is not treated as maintainer consensus on the broader API.

```yaml
spec:
  talos:
    sysctls:
      user.max_user_namespaces: "11255"
```

- Empty or omitted maps preserve the existing rendered machine
configuration and bootstrap hash. A literal `"0"` is an explicit
override; remove the entry to restore the Talos default.
- The existing content-hashed TalosConfigTemplate mechanism updates the
MachineDeployment bootstrap reference when overrides change. No new
rollout mechanism is introduced.
- Both keys and values are YAML-quoted, then shell-escaped for
backslashes, dollars and backticks before entering the unquoted
reconcile Job heredoc. Quoting scalars individually also keeps newlines
and Unicode line separators from breaking the surrounding YAML or
heredoc delimiter.
- Both the generated schema and a render-time guard enforce string
values. The template guard is tested with schema validation disabled
too.
- Regenerates the schema, parameter reference, Go API type/deepcopy and
ApplicationDefinition. The README table alignment change is generator
output.

This changes only the selected pool's guest configuration, not the
management hosts, control plane or other pools. Supported sysctls and
their semantics remain Talos/kernel-dependent; inappropriate settings
can weaken guest isolation or prevent boot. Installing the gVisor
extension, configuring its RuntimeClass and enforcing workload/network
restrictions remain separate steps.

### Validation

- `helm unittest packages/apps/kubernetes-nodes`: 40 suites, 245 tests
and 12 existing snapshots passed, without updating snapshots.
- `bats hack/check-talosconfigtemplate-name-agreement.bats
hack/talos-reconcile-heredoc_test.bats`: all 16 tests passed (5
name-agreement and 11 heredoc tests). Covers Job/Role/MachineDeployment
name agreement, changed and restored hashes, explicit zero, schema and
template type rejection, invalid UTF-8 file inputs, and a literal
round-trip through the actual manifest-producing heredoc under Bash and
Dash. Hostile keys/values include command substitutions, backticks,
variable references, backslashes, quotes, newlines and Unicode
separators; no marker command executes, and runtime placeholders still
expand. The UTF-8 regression was observed failing before the fix with
schema validation disabled; valid Unicode including U+FFFD remains
accepted.
- `bats hack/bats-no-exit-trap.bats hack/bats-no-negated-assert.bats`:
all 32 tests passed.
- Package `make generate` with cozyvalues-gen v1.7.0 and root `make
generate`: repeat runs are idempotent. Root `make manifests` passed.
- `go test ./kubernetesnodes` and `go vet ./kubernetesnodes` in
`api/apps/v1alpha1` passed; the generated API package has no test files.

No live cluster rollout or gVisor execution was tested for this PR.
`make show` could not run because `cozyhr` is unavailable locally;
offline chart rendering is exercised by the Helm and BATS tests above.
Worker replacement and rollback still need staging validation. This
main-branch change is not drop-in support for the release-1.6 nodeGroups
API.

### Screenshots

Not applicable; no UI changes.

<!-- REQUIRED for UI changes: attach screenshots or screen recordings
demonstrating
the visual impact of your changes. PRs with UI changes without
screenshots will not be merged. -->

### Downstream repositories

<!--
Cozystack is upstream for repositories that are NOT kept in sync with it
automatically, and nothing in CI compares the two sides, so a change
here can break them silently.

Which change forces what, and which file to touch, is the trigger map in
docs/agents/contributing.md under "Downstream Repositories". Walk it
before you tick anything.

IF YOU ARE AN AI AGENT OR AN LLM, THIS IS PART OF THE TASK, NOT A FORM
TO FILL IN:

1. Walk the trigger map against the actual diff of this PR, file by
file. Do not decide from the PR title or from your memory of what you
changed.
2. For every repository you tick, open the follow-up PR there and link
it on the same line. A ticked box with no link claims work that does not
exist, which is worse than an empty box. Search that repository for an
open PR or issue covering it first, and link that instead of filing a
duplicate.
3. When the follow-up is out of scope, or needs a decision that is not
yours to make, open an issue in that repository instead, link that, and
say so in the PR body. Do not push a speculative PR into another
repository just to fill a line here.
4. Do not tick "No downstream repository is affected" to make the
checklist go away. If you are unsure, leave every box empty and say so
in the PR body, so a human decides.
-->

- [ ] No downstream repository is affected by this change
- [ ] [cozystack/website](https://github.com/cozystack/website) - the
existing `K8S_NODES` reference imports this package's generated README
at release; no manual docs contract changes.
- [x]
[cozystack/terraform-provider-cozystack](https://github.com/cozystack/terraform-provider-cozystack)
- follow-up:
https://github.com/cozystack/terraform-provider-cozystack/issues/72;
adapt the existing follow-up to the general `talos.sysctls` map after
the upstream API is accepted, rather than implementing the superseded
dedicated field.
- [ ]
[cozystack/ansible-cozystack](https://github.com/cozystack/ansible-cozystack)
- follow-up:
- [ ] [cozystack/ccp](https://github.com/cozystack/ccp) - follow-up:
- [ ] [cozystack/talm](https://github.com/cozystack/talm) - follow-up:
- [ ] [cozystack/cozyhr](https://github.com/cozystack/cozyhr) -
follow-up:
- [ ] [cozystack/cozy-proxy](https://github.com/cozystack/cozy-proxy) -
follow-up:
- [ ]
[cozystack/cozystack-telemetry-server](https://github.com/cozystack/cozystack-telemetry-server)
- follow-up:
- [ ]
[cozystack/external-apps-example](https://github.com/cozystack/external-apps-example)
- follow-up:
- [ ] [cozystack/examples](https://github.com/cozystack/examples) -
follow-up:
- [ ] [cozystack/community](https://github.com/cozystack/community) -
follow-up:

The other trigger-map entries are unaffected: no management-node
prerequisite, package name, controller contract, tooling, image or
release convention changes. No downstream implementation or live
deployment is included.

### Release note

<!--  Write a release note:
- Explain what has changed internally and for users.
- Start with the same `type(scope):` prefix as in the PR title
- Follow the guidelines at
https://github.com/kubernetes/community/blob/master/contributors/guide/release-notes.md.
-->

```release-note
feat(kubernetes): add an optional per-pool KubernetesNodes talos.sysctls string map for Talos worker machine.sysctls overrides, preserving defaults and using the existing bootstrap rollout mechanism.
```


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
<!-- coderabbit-ai-generated:v1 -->

## Summary by CodeRabbit

* **New Features**
* Added optional string-valued sysctl overrides for worker nodes in a
pool. The default is empty and preserves existing behavior. Adding,
changing, or removing overrides updates the worker configuration and
rolls the pool.
* **Bug Fixes**
* Invalid sysctl configuration types and invalid UTF-8 values are
rejected during validation.
* **Documentation**
* Documented the setting’s scope, rollout behavior, and compatibility
considerations, including that it does not configure gVisor. Clarified
HTTPS certificate configuration and when it applies.
* **Improvements**
* Adjusted installation waiting behavior and timeout for Kubernetes node
pools. Updated the ordering of displayed configuration options.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-11-16 21:30:35 +03:00
2026-11-04 00:56:56 +01:00
2025-10-08 09:43:34 +05:00
2024-02-08 12:04:32 +01:00

Cozystack Cozystack

GitHub Release Apache-2.0 License Commit activity OpenSSF Best Practices OpenSSF Scorecard CLOMonitor Support

Cozystack

Cozystack is a free and open-source platform and framework for building clouds.

Cozystack is a CNCF Sandbox project that was originally built and sponsored by Ænix.

With Cozystack, you can transform a bunch of servers into an intelligent system with a simple REST API for spawning Kubernetes clusters, Database-as-a-Service, virtual machines, load balancers, HTTP caching services, and other services with ease.

Use Cozystack to build your own cloud or provide a cost-effective development environment.

Cozystack user interface

Use-Cases

Documentation

The documentation is located on the cozystack.io website.

Read the Getting Started section for a quick start.

If you encounter any difficulties, start with the troubleshooting guide and work your way through the process that we've outlined.

Versioning

Versioning adheres to the Semantic Versioning principles.
A full list of the available releases is available in the GitHub repository's Release section.

Contributions

Contributions are highly appreciated and very welcomed!

In case of bugs, please check if the issue has already been opened by checking the GitHub Issues section. If it isn't, you can open a new one. A detailed report will help us replicate it, assess it, and work on a fix.

You are welcome to take on the fix yourself. Commits are used to generate the changelog, and their author will be referenced in it.

If you have a concrete feature request, open an issue. For a cross-cutting or architectural change, open a design proposal in the community repo. For questions or early ideas, use GitHub Discussions. See CONTRIBUTING.md for the full routing.

Community

You are welcome to join us in #cozystack, on either CNCF Slack (get an invite) or Kubernetes Slack (get an invite), in our Telegram group, and at our community meetings. Add them to your Google Calendar or iCal for convenience.

Project documents

Document What it covers
Governance How decisions are made and who makes them
Contributor Ladder How to grow from contributor to maintainer
Maintainers Who maintains the project
Code of Conduct What we expect of each other
Security Policy Reporting a vulnerability, and which releases get fixes
Adopters Who runs Cozystack in production
Roadmap Where the project is going

License

Cozystack is licensed under Apache 2.0.
The code is provided as-is with no warranties.

Commercial Support

A list of companies providing commercial support for this project can be found on official site.

Languages
Go 52%
Shell 34%
TypeScript 6.8%
Go Template 4.7%
Makefile 1.3%
Other 1.1%