4556 Commits
Author SHA1 Message Date
Ivan Starkov 59b4050b0c build: Release 0.134.0 (#2935)
## Description

1. What is this PR about (link the issue and add a short description)

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
0.134.0
2024-02-22 22:23:49 +03:00
Oleg Isonen 0e4cc4c5bd feat: Expand HTML editor (#2934)
## Description

Allow user to see code in a bigger editor for HTML Embed

## Steps for reproduction

1. insert html embed
2. click on expand button in the editor

## Code Review

- [ ] hi @istarkov , I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
2024-02-22 22:23:38 +03:00
Oleg Isonen 35efee6c4f fix: Don't auto replace embed code if the value required changes after sanitization (#2933)
## Description

Sanitization and autoSave in code of the embed prevents user from typing
invalid code. Now it will be allowed, error shown separately along with
a button for auto fixing.

https://share.descript.com/view/Baf4D4AFzkH

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @TrySound , I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
2024-02-22 18:59:49 +01:00
Ivan Starkov 979d0fa5d9 feat: Preload page font and background-image assets (#2932)
## Description

Add background images and fonts to link rel preload (to reduce FCP, LCP
and Layout Shift)

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
2024-02-22 15:53:08 +03:00
Jaya Krishna Namburu 59593e313b feat: allow users to set custom redirect status code (#2930)
## Description

Allow users to configure `301` or `302` status code for redirects.

## Steps for reproduction

- Go to project settings
- Add a redirect
- Select a status code from the dropdown at the time of adding a
redirect.
- When the project is deployed, and redirects should reflect the status
code that is added in project settings.

![Screenshot 2024-02-21 at 13 48
18](https://github.com/webstudio-is/webstudio/assets/11075561/69999f06-8140-4b98-b095-eda32530047b)


## Code Review

- [ ] hi @kof   I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [x] made a self-review

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
2024-02-21 12:35:18 +01:00
Bogdan Chadkin 9e37075e7d refactor: move insert instance children logic into utility (#2931)
Here split and consolidated utility for adding children to instances. It
can be universally reused almost everywhere.
2024-02-21 17:08:10 +07:00
Bogdan Chadkin 727978b2c9 fix: prevent generating unused variables in resoures (#2929)
Here improved the resources generator to not produce variables unused in
resource fields.

Also enforced unused variables to be always provided to avoid issues
with not generated variables.
2024-02-20 13:10:38 +07:00
Bogdan Chadkin bf6223902e refactor: allow to extract webstudio fragment from any data (#2927)
Here refactored to extract fragment or copy from any data not only
global stores.
2024-02-19 17:33:26 +07:00
Bogdan Chadkin 9206d45ac5 experimental: use dynamic page icon in pages navigator (#2926)
Ref https://github.com/webstudio-is/webstudio/issues/2903

Here added new isPathnamePattern utility to check the path is dynamic.
We can use to change the icon in pages list.

<img width="435" alt="Screenshot 2024-02-18 at 21 01 02"
src="https://github.com/webstudio-is/webstudio/assets/5635476/cca0fdeb-5576-4c7d-a905-92e9061d9add">
2024-02-19 11:22:04 +07:00
Bogdan Chadkin 4f06445e93 experimental: move address bar to topbar (#2921)
Ref https://github.com/webstudio-is/webstudio/issues/2903

<img width="345" alt="Screenshot 2024-02-18 at 13 05 42"
src="https://github.com/webstudio-is/webstudio/assets/5635476/5348a2c2-a1ca-4c58-bc25-95ddace948a3">
<img width="948" alt="Screenshot 2024-02-18 at 13 05 27"
src="https://github.com/webstudio-is/webstudio/assets/5635476/e14dfb6d-084d-40f4-a920-4afb868137c3">


Fixed
https://discord.com/channels/955905230107738152/1208193507668394094 too
2024-02-18 20:35:23 +07:00
Bogdan Chadkin c74b4fc6e8 fix: use editing page scope instead of selected page (#2923)
Ref https://github.com/webstudio-is/webstudio/issues/2903

Here fixing an issue with showing scope of selected page instead of
currently opened in editor.
2024-02-18 17:57:50 +07:00
Oleg Isonen 15c653abe5 fix: Fix unnecessary separator (#2922)
## Description

We have 2 separators between redirects section in project settings, when
Redirects are enabled


## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
2024-02-18 11:47:08 +01:00
Bogdan Chadkin 3863abec2a refactor: rename instances slice to webstudio fragment (#2925)
Here renamed everywhere in the code instances slice to webstudio
fragment to keep naming consistent across whole app.
2024-02-18 17:43:07 +07:00
Oleg Isonen 1888fed507 docs: Update README.md (#2924)
## Description

1. What is this PR about (link the issue and add a short description)

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
2024-02-18 11:36:30 +01:00
Oleg Isonen 233d6bf429 chore: Improve copy to clipboard experience (#2920)
## Description

- more decent copy to clipboard button with tooltip expaining the state

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
2024-02-16 14:23:58 +01:00
Bogdan Chadkin 51e2693872 experimental: improve address bar UI (#2919)
Ref https://github.com/webstudio-is/webstudio/issues/2903

Now it looks more like address bar and provides validation for required
or non-splat params with slashes. To make it work implemented tokenizer
and improved pattern compiler.

<img width="457" alt="Screenshot 2024-02-16 at 14 20 02"
src="https://github.com/webstudio-is/webstudio/assets/5635476/478478cc-c0b7-4968-b9e0-43be8d82f3bb">
<img width="764" alt="Screenshot 2024-02-16 at 14 19 43"
src="https://github.com/webstudio-is/webstudio/assets/5635476/cef0803f-d65f-4a26-887b-450ef7d7aa8d">
2024-02-16 19:44:35 +07:00
Oleg Isonen be593f7dd0 feat: Custom attributes / properties (#2912)
Closes https://github.com/webstudio-is/webstudio/issues/1012

## Description

I decided to just use the same control to add a custom
property/attribute, it works same way as adding style sources.

## Steps for reproduction

## Code Review

- [ ] hi @TrySound , I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
2024-02-16 10:59:36 +01:00
Jaya Krishna Namburu 7e8896cb75 experimental: Add support for redirects in deployment (#2824)
## Description

WIP, still a lot of cases to cover. Please don't review yet

1. What is this PR about (link the issue and add a short description)

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
2024-02-16 06:46:41 +01:00
Bogdan Chadkin e95133fb23 experimental: add pro banner to page settings (#2918)
Ref https://github.com/webstudio-is/webstudio/issues/2903

<img width="575" alt="Screenshot 2024-02-15 at 17 52 00"
src="https://github.com/webstudio-is/webstudio/assets/5635476/54124996-e857-45bf-adfa-ec14b5a4aadd">
2024-02-15 23:51:48 +07:00
Oleg Isonen f9349c6ac3 fix: Fix truncation of a long page name in the top bar button (#2917)
## Description

With the introduction of a button in the top bar we forgot to truncate
when page name is too long

## Steps for reproduction

1. create a page with a very long name
2. see it's name being truncated in the top bar

## Code Review

- [ ] hi @TrySound , I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
2024-02-15 14:55:40 +01:00
Bogdan Chadkin be2b5ce31a refactor: rename page.pathVariableId to pathParamsDataSourceId (#2915)
Ref https://github.com/webstudio-is/webstudio/issues/2903

Small renaming for clarity
2024-02-15 19:31:55 +07:00
Bogdan Chadkin cf3ad4a0a1 experimental: disable status and redirect for hobby users (#2914)
Ref https://github.com/webstudio-is/webstudio/issues/2903

<img width="530" alt="Screenshot 2024-02-15 at 12 16 25"
src="https://github.com/webstudio-is/webstudio/assets/5635476/e4eca9e6-fc27-42e8-a3f3-9b7bc742f90d">
<img width="515" alt="Screenshot 2024-02-15 at 12 16 20"
src="https://github.com/webstudio-is/webstudio/assets/5635476/18ff8acb-fc8c-4d1c-9e42-8c9cdd1d193e">
<img width="452" alt="Screenshot 2024-02-14 at 22 34 04"
src="https://github.com/webstudio-is/webstudio/assets/5635476/f9963d97-8e8d-456d-a354-aa61d1816b93">
2024-02-15 12:20:19 +07:00
Bogdan Chadkin 9f263b2f5e experimental: put dynamic path behind feature flag (#2913)
Ref https://github.com/webstudio-is/webstudio/issues/2903

Added additional validation for hobby users to forbid dynamic path
parameters and disable copy address button.


<img width="453" alt="Screenshot 2024-02-14 at 16 00 31"
src="https://github.com/webstudio-is/webstudio/assets/5635476/a58aecf5-2b06-4f3d-9e8d-06eb2fe3bf5f">
<img width="737" alt="Screenshot 2024-02-14 at 15 53 52"
src="https://github.com/webstudio-is/webstudio/assets/5635476/e3e9b5cf-a571-4897-b415-1240d97e71cc">
2024-02-14 22:11:01 +07:00
Bogdan Chadkin 4c20e2d317 refactor: avoid generating unused variables in page components (#2906)
Here improved component generator logic to not generate unused
variables. This way later we will be able to avoid requesting unused
resources as well.
2024-02-14 11:50:10 +07:00
Oleg Isonen ecb990d73d build: Release 0.133.0 (#2910)
## Description

1. What is this PR about (link the issue and add a short description)

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
0.133.0
2024-02-13 20:49:56 +01:00
Oleg Isonen 6887463746 feat: Scrub improvements (#2904)
## Description

1. Allow scrub on any css value that can be numeric, no matter what
current keyword value might be selected
2. Adjust scrub speed depending on the unit

## Steps for reproduction

1. try scrubing any css value 
3. backdrop fill in the effects section won't allow to scrub , which is
correct
4. try changing dfferent units and see how it feels, if the speed is
appropriate

## Code Review

- [ ] hi @istarkov , I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview
  

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
2024-02-13 20:12:09 +01:00
Ivan Starkov 33fd11d929 fix: Popover content position change to absolute throw error on canvas (#2909)
## Description

closes #2735

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
2024-02-13 20:40:41 +03:00
Ivan Starkov e67b13d64d fix: Dialog focus issues (#2908)
## Description

closes #2889

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
2024-02-13 20:40:28 +03:00
Oleg Isonen 2e5e116b47 chore: Change tabs order (#2907)
## Description

Just changed the order because it makes no sense to have assets before
pages and navigator

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
2024-02-13 18:24:50 +01:00
Oleg Isonen 66f36a0e83 feat: Autosave settings (#2897)
## Description

This makes all changes in settings panel inside inputs, textareas and
code input save automatically with slight debounce, without waiting for
blur etc.

## Steps for reproduction

1. try to change any input/textarea/code
2. change should apply right away

## Code Review

- [ ] hi @TrySound , I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
2024-02-13 13:40:19 +01:00
Bogdan Chadkin 646245f21a experimental: allow changing page status (#2905)
Ref https://github.com/webstudio-is/webstudio/issues/2903

Here added support for changing page status in page settings. This works
for both redirect and content rendering.

User can render error message based on received cms data and give 404
status code.
2024-02-13 18:37:24 +07:00
Oleg Isonen 9efc764898 feat: Add all input types (#2901)
## Description

With this pr we are enabling all input types



https://github.com/webstudio-is/webstudio/assets/52824/0a09928d-68b6-4e0d-964e-7c19e92dc61a


## Steps for reproduction

1. add text input
2. try different types

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
2024-02-13 12:19:51 +01:00
Oleg Isonen b3b1792eae fix: Image on canvas in latest chrome may not render when loading is lazy (#2902)
## Description

When on canvas inside builder we need to always eager load images to
avoid this bug in latest chrome with cache turned off

## Steps for reproduction

1. turn off cache
2. add image component on canvas
3. see it renders as expected (loading lazy in settings is default, but
on canvas it renders as loading eager)

## Code Review

- [ ] hi @istarkov , I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
2024-02-13 12:19:07 +01:00
Bogdan Chadkin 231f91c69c experimental: add redirect field to page settings (#2900)
Here added new field to page settings ui and page meta schema to
redirect page when specified. Having bindings support redirect can be
specified conditionally based on cms cata.

Tested locally, works with both urls and paths.

<img width="702" alt="Screenshot 2024-02-12 at 15 58 11"
src="https://github.com/webstudio-is/webstudio/assets/5635476/a4c171b4-8091-4241-b36f-401fc543427c">
2024-02-13 00:01:52 +07:00
Oleg Isonen 6e503ce98a fix: Fix shared link deletion crash (#2899)
## Description

When deleting a link, blur event from link name triggers an update,
which executes after link has been deleted

## Steps for reproduction

1. create a link
2. delete it
3. should not crash

## Code Review

- [ ] hi @TrySound , I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
2024-02-12 14:04:37 +01:00
Bogdan Chadkin 4a6c91bf31 experimental: generate variables for page meta website (#2898)
Here added support for variables in page meta in generated websites.
Prevented creating unused variables. We can reuse the same way for other
generated parts later.
2024-02-11 20:53:19 +07:00
Bogdan Chadkin ffff4e5beb refactor: improve copy page url (#2896)
- moved copy url to address bar
- support copy with keyboard
- persist copied state for 2 seconds
2024-02-11 20:00:48 +07:00
Oleg Isonen b85d256645 fix: Fix tokens outside click accidentally creating tokens (#2893)
## Description

We were using popper in combobox and that is not handling click outside,
so a click outside has resulted in selected item change.

In case of style source we were creating a new token instead of just
closing the completion popover

## Steps for reproduction

It affects all places where we use combobox:

- style source
- css value
- transition property value
- settings > new property



https://github.com/webstudio-is/webstudio/assets/52824/4019e57f-3072-476f-a525-0d49b742df79


## Code Review

- [ ] hi @TrySound , I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
2024-02-11 13:04:33 +01:00
Oleg Isonen a34afe8160 fix: Show advanced typography styles state using ellipsis icon dots (#2888)
## Description

Since advanced typography options are 1 menu click hidden, there was no
way to know if they are set when looking at the panel, I decided to get
creative and used the ellipsis icon dots same way we use dots on the
panel title, slightly increased their size to make it visible

<img width="236" alt="image"
src="https://github.com/webstudio-is/webstudio/assets/52824/388f6309-9ae2-4a7e-a43e-557d3cf97530">


## Steps for reproduction

1. define advanced typography options
2. see dots change colors, same way as the section title dots when
closed

## Code Review

- [ ] hi @TrySound , I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
2024-02-10 19:47:50 +01:00
Oleg Isonen 393cad2c0b fix: fix color picker updating value and not selecting text when outside (#2892)
https://github.com/webstudio-is/webstudio/issues/2890

Previous attempt to prevent selection resulted in not updating the value
in the picker

## Description

When dragging color handle it should be updating the hex value and when
dragging outside of the picker it should not select the entire text


## Code Review

- [ ] hi @istarkov , I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
2024-02-10 19:47:06 +01:00
Oleg Isonen dbf84eb990 chore: Update wording on the view permission (#2894)
## Description

Description was outdated

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
2024-02-10 19:46:19 +01:00
Bogdan Chadkin 29df24bfaf experimental: update variables when duplicate page (#2886)
Here improved page duplicate logic to support replacing old variables in
page meta and path params variable with new references.

Also improved path duplicating to preserve path params by prefixing with
`/copy-n` subpath.
2024-02-09 23:53:37 +07:00
Oleg Isonen 2a0556ae96 fix: Allow opening pages from topbar when in preview mode (#2885)
## Description

Topbar pages button works when in build mode, but in preview it doesn't,
this changes it. So one can switch pages when in preview mode

## Steps for reproduction

1. switch to preview mode
2. toggle pages button in top bar

## Code Review

- [ ] hi @TrySound , I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
2024-02-09 15:13:38 +01:00
Oleg Isonen c4670f501c build: npm release 0.132.0 (#2884)
## Description

1. What is this PR about (link the issue and add a short description)

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
0.132.0
2024-02-08 20:59:12 +01:00
Oleg Isonen f3c815d524 fix: Fix clone from builder when shared link is used (#2883)
## Description

Clone had no authToken provided via shared url

## Steps for reproduction

1. create a shared url with view permission
2. open it from a different account
3. clone from menu should work

## Code Review

- [ ] hi @istarkov , I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
2024-02-08 20:51:56 +01:00
Bogdan Chadkin af672a8df8 refactor: improve path params (#2882)
- generate path params fields on the fly, even for new page
- fill entered values when path params variable is created
- fixed showing $ws$dataSource$id instead of variable name when no
values path params entered
- renamed variable to "Path Params"
2024-02-08 17:50:40 +07:00
Ivan Starkov 78a5e3c916 build: Release 0.131.0 (#2880)
## Description

1. What is this PR about (link the issue and add a short description)

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
0.131.0
2024-02-08 00:51:52 +03:00
Oleg Isonen cd4faac416 fix: Loading indicator was deactivated (#2879)
## Description

In the previous attempt to fix React warnings I accidentally deactivated
the loading indicator completely, now this fix works.

## Steps for reproduction

1. click on any project
2. see loading indicator right away

## Code Review

- [ ] hi @istarkov , I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
2024-02-07 21:52:28 +01:00
Oleg Isonen 22be073e6c fix: Return the check for templates permission (#2878)
## Description

We just removed that check for the wrong reasons, readding it back
before we ca find a better solution and avoid having a shortlist check
in the permissions check

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @istarkov , I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
2024-02-07 21:28:58 +01:00
Ivan Starkov f21442b3b9 build: Release 0.130.0 (#2877)
## Description

1. What is this PR about (link the issue and add a short description)

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
0.130.0
2024-02-07 20:37:44 +03:00